Pixel Alpaka Migration: Modification to Existing Modules [I] by AdrianoDee · Pull Request #41282 · cms-sw/cmssw

AdrianoDee · 2023-04-05T15:47:26Z

PR description:

This PR stems from #41117 and it's the 1st of a series of smaller PRs.

This includes the changes to pre-existing modules or headers (BuildFiles not included here).
A single real change to include the max number of hits in the the topologies.

This PR and #41284, once reviewed, may be merged as they are. They do not depend on the other PRs.

PR validation:

It compiles. Running base tests. No regression expected.

This will be immediately back ported to 13_0_X.

slava77 · 2023-04-05T15:51:28Z

RecoTracker/PixelSeeding/plugins/CAStructures.h

-#ifndef CUDADataFormats_TrackerGeometry_CAStructures_h
-#define CUDADataFormats_TrackerGeometry_CAStructures_h
+#ifndef RecoPixelVertexing_PixelTriplets_CAStructures_h
+#define RecoPixelVertexing_PixelTriplets_CAStructures_h


perhaps RecoTracker_PixelSeeding ?

cmsbuild · 2023-04-05T15:54:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41282/35058

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/CommonTopologies/interface/SimplePixelTopology.h modified in PR(s): Porting Pixel Tracks to Alpaka [Not to Merge] #41117
- File RecoTracker/PixelSeeding/plugins/CAStructures.h modified in PR(s): Porting Pixel Tracks to Alpaka [Not to Merge] #41117
- File RecoTracker/PixelTrackFitting/plugins/PixelTrackProducerFromSoA.cc modified in PR(s): Porting Pixel Tracks to Alpaka [Not to Merge] #41117

cmsbuild · 2023-04-05T15:55:19Z

A new Pull Request was created by @AdrianoDee (Adriano Di Florio) for master.

It involves the following packages:

Geometry/CommonTopologies (geometry)
RecoTracker/PixelSeeding (reconstruction)
RecoTracker/PixelTrackFitting (reconstruction)

@civanch, @Dr15Jones, @makortel, @clacaputo, @cmsbuild, @bsunanda, @mdhildreth, @mandrenguyen can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @bsunanda, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2023-04-05T16:01:25Z

please test

cmsbuild · 2023-04-05T16:03:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41282/35064

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/CommonTopologies/interface/SimplePixelTopology.h modified in PR(s): Porting Pixel Tracks to Alpaka [Not to Merge] #41117
- File RecoTracker/PixelSeeding/plugins/CAStructures.h modified in PR(s): Porting Pixel Tracks to Alpaka [Not to Merge] #41117
- File RecoTracker/PixelTrackFitting/plugins/PixelTrackProducerFromSoA.cc modified in PR(s): Porting Pixel Tracks to Alpaka [Not to Merge] #41117

cmsbuild · 2023-04-05T16:03:40Z

Pull request #41282 was updated. @civanch, @Dr15Jones, @makortel, @clacaputo, @bsunanda, @mdhildreth, @mandrenguyen can you please check and sign again.

AdrianoDee · 2023-04-05T16:32:01Z

please test

cmsbuild · 2023-04-05T19:18:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-496357/31849/summary.html
COMMIT: fadde5d
CMSSW: CMSSW_13_1_X_2023-04-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41282/31849/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 31 lines to the logs
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3365163
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3365135
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 202 log files, 155 edm output root files, 47 DQM output files
TriggerResults: no differences found

Co-authored-by: Adriano Di Florio <[email protected]> Co-authored-by: Breno Orzari <[email protected]> Co-authored-by: Dimitris Papagiannis <[email protected]>

cmsbuild · 2023-04-18T08:31:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41282/35212

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/CommonTopologies/interface/SimplePixelTopology.h modified in PR(s): Porting Pixel Tracks to Alpaka [Not to Merge] #41117
- File RecoTracker/PixelTrackFitting/plugins/PixelTrackProducerFromSoA.cc modified in PR(s): Porting Pixel Tracks to Alpaka [Not to Merge] #41117

cmsbuild · 2023-04-18T08:32:12Z

Pull request #41282 was updated. @civanch, @Dr15Jones, @makortel, @clacaputo, @cmsbuild, @bsunanda, @mdhildreth, @mandrenguyen can you please check and sign again.

AdrianoDee · 2023-04-18T08:32:26Z

please test

cmsbuild · 2023-04-18T11:28:26Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-496357/32014/summary.html
COMMIT: 720c885
CMSSW: CMSSW_13_1_X_2023-04-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41282/32014/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3459609
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3459581
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

perrotta · 2023-04-18T11:38:26Z

+1

Technical
Already signed by reco, see Pixel Alpaka Migration: Modification to Existing Modules [I] #41282 (comment)
Signature from @cms-sw/geometry-l2 still required, but changes in Geometry/CommonTopologies/interface/SimplePixelTopology.h are trivial, and we can bypass it

perrotta · 2023-04-18T11:54:37Z

merge

jfernan2 · 2023-09-18T17:48:56Z

+1
for the records

cmsbuild added this to the CMSSW_13_1_X milestone Apr 5, 2023

cmsbuild added reconstruction-pending geometry-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Apr 5, 2023

AdrianoDee mentioned this pull request Apr 5, 2023

[13_0_X] Pixel Alpaka Migration: Modification to Existing Modules [I] #41283

Merged

slava77 reviewed Apr 5, 2023

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 5, 2023

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 5, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 5, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 5, 2023

cmsbuild added the code-checks-rejected label Apr 18, 2023

Alpaka Migration: trivial changes to exisiting modules

720c885

Co-authored-by: Adriano Di Florio <[email protected]> Co-authored-by: Breno Orzari <[email protected]> Co-authored-by: Dimitris Papagiannis <[email protected]>

AdrianoDee force-pushed the alpaka_port_13_1_extras branch from c753691 to 720c885 Compare April 18, 2023 08:25

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-rejected labels Apr 18, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 18, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 18, 2023

cmsbuild added tests-approved and removed tests-started labels Apr 18, 2023

cmsbuild added orp-approved and removed orp-pending labels Apr 18, 2023

cmsbuild merged commit d1eee09 into cms-sw:master Apr 18, 2023

cmsbuild mentioned this pull request Apr 18, 2023

Rocm/Cuda unit test improvement cms-sw/cmssw-config#95

Merged

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Sep 18, 2023

This was referenced Nov 15, 2023

Pixel Alpaka Migration: Configs and Fixes [VII] #43294

Merged

Pixel Alpaka Migration: Portable Product [II] #43295

Merged

fwyzard mentioned this pull request Jan 26, 2024

Follow up to the Pixel alpaka migration #43796

Open

2 tasks

AdrianoDee deleted the alpaka_port_13_1_extras branch February 11, 2025 14:21

Conversation

AdrianoDee commented Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

slava77 Apr 5, 2023

Choose a reason for hiding this comment

Uh oh!

AdrianoDee Apr 5, 2023

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Apr 5, 2023

Uh oh!

cmsbuild commented Apr 5, 2023

Uh oh!

AdrianoDee commented Apr 5, 2023

Uh oh!

cmsbuild commented Apr 5, 2023

Uh oh!

cmsbuild commented Apr 5, 2023

Uh oh!

AdrianoDee commented Apr 5, 2023

Uh oh!

cmsbuild commented Apr 5, 2023

Comparison Summary

Uh oh!

cmsbuild commented Apr 18, 2023

Uh oh!

cmsbuild commented Apr 18, 2023

Uh oh!

AdrianoDee commented Apr 18, 2023

Uh oh!

cmsbuild commented Apr 18, 2023

Comparison Summary

Uh oh!

perrotta commented Apr 18, 2023

Uh oh!

perrotta commented Apr 18, 2023

Uh oh!

jfernan2 commented Sep 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

AdrianoDee commented Apr 5, 2023 •

edited

Loading